Commit Diff
Diff:
8d4adc5aba58af85442af2b2671a36967abccd11
495bff70449b9a4bd0eda8407752867390116181
Commit:
495bff70449b9a4bd0eda8407752867390116181
Tree:
353d4afa53698db862b48a64718e4607bfc1bef8
Author:
pjp <pjp@delphinusdns.org>
Committer:
pjp <pjp@delphinusdns.org>
Date:
Sun Jul 19 08:02:13 2020 UTC
Message:
remove a commented out (with C++ style! comments) line, add more informative logging to expand_compression() failures
blob - 2fa3a83c4f165386ad4858530abea68d78c1ff33
blob + f8b27ce711674eb4142dc4c2065a066f4f309c3a
--- util.c
+++ util.c
@@ -27,7 +27,7 @@
*/
/*
- * $Id: util.c,v 1.73 2020/07/16 14:37:55 pjp Exp $
+ * $Id: util.c,v 1.74 2020/07/19 08:02:13 pjp Exp $
*/
#include <sys/types.h>
@@ -1117,7 +1117,6 @@ build_question(char *buf, int len, int additional, cha
q->dnssecok = 1;
i += 11 + ntohs(opt->rdlen);
- // i += sizeof(struct dns_optrr);
additional--;
} while (0);
/* check for TSIG rr */
@@ -1155,7 +1154,7 @@ build_question(char *buf, int len, int additional, cha
pb = expand_compression((u_char *)&buf[i], (u_char *)buf, (u_char *)&buf[len], (u_char *)&expand, &elen, sizeof(expand));
if (pb == NULL) {
free_question(q);
- dolog(LOG_INFO, "expand_compression() failed\n");
+ dolog(LOG_INFO, "expand_compression() failed, tsig keyname\n");
return NULL;
}
i = (pb - buf);
@@ -1228,7 +1227,7 @@ build_question(char *buf, int len, int additional, cha
pb = expand_compression((u_char *)&buf[i], (u_char *)buf, (u_char *)&buf[len], (u_char *)&expand, &elen, sizeof(expand));
if (pb == NULL) {
free_question(q);
- dolog(LOG_INFO, "expand_compression() failed 2\n");
+ dolog(LOG_INFO, "expand_compression() failed, tsig algorithm name\n");
return NULL;
}
i = (pb - buf);
repomaster@centroid.eu